[Web UI] Filter entities by given subscription #1656
Conversation
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
jamesdphillips
added
ready-for-review
component:web-ui
| static fragments = { | ||
| subscriptions: gql` | ||
| fragment EntitiesListHeader_subscriptions on SubscriptionSet { | ||
| entries(orderBy: FREQUENCY) |
There was a problem hiding this comment.
Does this run the risk of returning a dangerously large result without a limit?
I think making this it's own query would be a good idea. With query batching there wouldn't be any overhead, and it would set us up for fetching this list in chunks if we need to or refetching it independently of the main page content.
There was a problem hiding this comment.
Does this run the risk of returning a dangerously large result without a limit?
From looking around the set could probably be in the hundreds, so it is probably worth adding a limit (and offset.) 👍
I think making this it's own query would be a good idea.
I like your thinking here, with a limit implemented, it would make it easy to implement react virtualized and friends. However, with the design in flux, I think I'll leave it as is for the time being. Lest I build a more involved solution all for naught.
| environment={environment} | ||
| loading={loading || aborted} | ||
| onQueryChange={this.props.setQueryParams} |
There was a problem hiding this comment.
Use onChangeQuery for consistency with other event handler props: on{EventName}{TargetName}
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
…tions Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
…tions Signed-off-by: James Phillips <[email protected]>
What is this change?
Why is this change necessary?
Closes #1582
Does your change need a Changelog entry?
undefinedDo you need clarification on anything?
nullWere there any complications while making this change?
0